c++ - How to factorize code properly? -



c++ - How to factorize code properly? -

i've basic programming question. imagine i've 2 functions definition practically same except vary in internal binary condition. rest of code in both functions practically same.

in order have readable , easy-to-maintain code, wondering whether there's improve solution other using bool parameter selects operation mode of functions? there design-pattern that?

in code below, i'm illustrating uncertainty 2 functions named doa() , dob(). dots (....) correspond code same both functions. created new donew() function additional boolean parameter chose appropriate functionality. however, note although possible solution, it's still inefficient because of duplicated code within body of both if conditions.

void doa( ..... ){ ..... ..... if(x!=y){ .... .... .... } ..... } void dob( ..... ){ ..... ..... if(x==y){ .... .... .... } ..... } void donew( ....., bool selectionmode ){ ..... ..... if(selectionmode == true){ if(x==y){ .... .... .... } } else{ if(x!=y){ .... .... .... } } ..... }

i utilize boolean parameter distinguisch between them. not utilize complicated pattern simple procedure.

i use

void doit(..., bool is_equal) { ... if((a == b) == is_equal) { // or: is_equal ^ (a == b) ... } ... }

to ultimatively cut down redundance. define independent names

void doa(...) { doit(..., true); } void dob(...) { doit(..., false); }

because consider flag parameters in api bad.

c++ function methods

Comments

Post a Comment

Popular posts from this blog

iphone - Dismissing a UIAlertView -

iphone - Dismissing a UIAlertView - i set in app purchase app, , when user taps button, purchase started. basically, tap button, , depending on speed on net connection, waiting 10 seconds until new alert view comes asking if purchase product. user tap button multiple times since nil came up, , multiple purchase alert views come up. additionally, maybe seen user app bug. in end, problem. i want alert view come spinning wheel says "loading..." when users taps purchase button. problem is, how dismiss when new alert view comes asking user if want purchase product? if ([uialertview alloc] says: @"whatever apple's alert view says") { //dismiss "loading..." alert view here } i uncertainty work, input appreciated. thanks! you need have access alertview. can this. create alertview instance var in app delegate , when want show loading initialize instance var assign property , when want dismiss phone call [alertviewinstance d...
Read more

c# - Can ProtoBuf-Net deserialize to a flat class? -

c# - Can ProtoBuf-Net deserialize to a flat class? - protobuf-net uses nested protobuf constructs back upwards inheritance. however, can made force properties flat target class has same properties inherited "serialized" version? see test illustration below. needless result of flat namespace null both properties. possible solution: re-create info flat.b first on property property basis. note: not prefered option. using system; namespace hierarchy { using protobuf; [protocontract] public class { [protomember(1)] public string prop1 { get; set; } } [protocontract] public class b : { public b() { } [protomember(1)] public string prop2 { get; set; } public override string tostring() { homecoming "prop1=" + prop1 + ", prop2=" + prop2; } } } namespace flat { using protobuf; [protocontract] p...
Read more

javascript - Change element in each JQuery tab to dynamically generated colors -

javascript - Change element in each JQuery tab to dynamically generated colors - i'm using jquery ui tabs widget , have button add together additional tabs. i'm tying each tab markers on map coordinating randomly generated color using function gen_color() { homecoming '#'+(math.random()*0xffffff<<0).tostring(16); } so each tab has color corresponds number of markers of same color on map. i'm trying add together 15x15 block of color within tab's tab left of it's label. right i'm using tabtemplate alternative , trying alter when new tab added: $tabs = $("#tabs").tabs({ tabtemplate: "<li><span class='ui-icon-color' style='background-color:#000000;'></span><a href='#{href}'>#{label}</a> <span class='ui-icon ui-icon-close'>remove tab</span></li>", selected: 0, add: funct...
Read more