php - Independent getter/setter methods, or combined? -



php - Independent getter/setter methods, or combined? -

while working on project, i've been making changes , browsing around existing framework api docs insight.

while perusing kohana docs, noticed getters/setters of given class typically combined:

public function someproperty($value = null){ if(is_null($value){ homecoming $this->_someproperty; } $this->_someproperty = $value; homecoming $this; }

rather than:

public function setsomeproperty($value){ $this->_someproperty = $value; homecoming $this; } public function getsomeproperty(){ homecoming $this->_someproperty; }

is there value in doing (the former), beyond lessening method count of given class? under understanding methods (functions in general) should more descriptive of action. other experienced developers cringe, tiny bit, when see this?

i surprised see popular framework utilize such conventions (i haven't used kohana of course)

i consider bad practise because violates commandqueryseparation. setting value changing state (command). getting value asking state (query). method should not both, 1 thing only.

also, it's not obvious method when it's called username, e.g. not have verb, or set. gets worse in example, because homecoming value either object or property value, not consistent.

moreover, getters (and setters) should used sparingly convolute api. more getters , setters have, more knowledge object required collaborators of object. if find objects asking other objects internals, chances misplaced responsibilities.

php oop naming-conventions kohana getter-setter

Comments

Post a Comment

Popular posts from this blog

iphone - Dismissing a UIAlertView -

iphone - Dismissing a UIAlertView - i set in app purchase app, , when user taps button, purchase started. basically, tap button, , depending on speed on net connection, waiting 10 seconds until new alert view comes asking if purchase product. user tap button multiple times since nil came up, , multiple purchase alert views come up. additionally, maybe seen user app bug. in end, problem. i want alert view come spinning wheel says "loading..." when users taps purchase button. problem is, how dismiss when new alert view comes asking user if want purchase product? if ([uialertview alloc] says: @"whatever apple's alert view says") { //dismiss "loading..." alert view here } i uncertainty work, input appreciated. thanks! you need have access alertview. can this. create alertview instance var in app delegate , when want show loading initialize instance var assign property , when want dismiss phone call [alertviewinstance d...
Read more

intellij idea - Update external libraries with intelij and java -

intellij idea - Update external libraries with intelij and java - simple plenty really. i'm using apache jars, i'll create changes jar's every often. these jars listed external libs in intelij (i.e classpath looking install dir of jar's). when create changes intelij doesn't seem know new implementation. have remove jar external library , re-ad it. does know have intelij picks changes automatically ? i've done clean , rebuild project had little effect. you can go preferences -> build, execution, deployment -> build tools -> maven -> importing , check box says import maven projects automatically . in mac, can command + shift + a , come in action reimport , click on reimport maven projects . intellij-idea
Read more

javascript - send data from a new window to previous window in php -

javascript - send data from a new window to previous window in php - i have image in main.php file : <img src="..\images\image.gif" class="cur" onclick="imgwin();"> when click on image below function has called : function imgwin() { imagewin=window.open("../pages/img.php","imagewin","toolbar=no,width=500,height=200,directories=no,menubar=no,scrollbars=yes"); } this function opens img.php in new window img.php file : <html> <head> <title>upload image</title> </head> <body> <form name="imgform" method="get" action="#"> address : <input type="file" name="imgurl" size="50"> description : <input type="text" name="description" size="50"> <input type="submit" value="sumbit...
Read more